Repository navigation
fix(escrow): splitRelease strips the nested escrow.metadata like the others - #686
Closed
yggdrasilworld wants to merge 3 commits into
Closed
yggdrasilworld wants to merge 3 commits into
yggdrasilworld wants to merge 3 commits into
Conversation
…others splitRelease returned raw Payment[] — a loaded payment.escrow relation carried Escrow.metadata (raw Soroban diagnostics, the class MergeFi#19 keeps server-side) straight to the client, while fund/findOne/release/refund all wrap in toPublicEscrow. Added toPublicPayment — strips the relation's metadata — and applied it. Resolves MergeFi#91
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
The stacked-merge base left three files unable to compile: - escrow.service.ts: overlapping invokeOnLockedEscrow returns (kept u64) - sponsors.controller.ts: interleaved validatePage/parsePagination + duplicate returns (kept validatePage — ParseIntPipe already gives numbers) - github-webhooks.service.spec.ts: missing it()/describe() closers Spec drift synced: fund() callerUserId arg, releasePartial's manager arg, lowercase role enum values, dto-shaped release()/splitRelease() calls, checksum-valid Stellar/UUID fixtures, and a StrKey stub in the jest mock. Real bug fixed along the way: FundEscrowDto.deadline had IsDateString + a @type(() => Date) transform — the Date it produces can never pass IsDateString, so every request with a deadline 400'd. Now IsDate, which still rejects Invalid-Date results.
findIssueByRepoAndNumber is positional (repoId, number) — the
{ where } object mocks silently returned undefined, so the MergeFi#47/MergeFi#309/MergeFi#310
tests never reached the bounty lookups. 36/36 pass.
Author
|
Verification — tests run (real jest, this PR's head)
Fixed while verifying: three mangled merges on the stacked base ( |
Author
|
Closing — the linked issue was closed upstream, so this lane can no longer merge. Work preserved on the branch if it is ever reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
splitReleasereturned rawPayment[]— a loadedpayment.escrowrelation carriedEscrow.metadata(raw Soroban diagnostics, the class #19 keeps server-side) straight to the client. Every other escrow route wraps intoPublicEscrow; this one didn't.Fix
Added
toPublicPayment— strips the nested relation'smetadata— and applied it tosplitRelease.Resolves #91
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e